Cactiusers.org

Hi,

Well based on my own need and the requests on this forum, I thought I would release the work I have started on making different views for monitor.





To install, copy extracted files into monitor directory. If you are patching the commands are below:

To test the patch


To patch the files:


As this hasn't been fully tested please let me know of any bugs.

.fri

Thanks to the site admins and of course the original creator, Jimmy Conner.
Requests welcome.

.fri

Nice patch. It doesn't seem to account for devices that are placed directly under a tree, but a simple 2 line patch fixes it nicely. I will be adding this to SVN shortly, and then we can all begin to really play with it.

THANKS FOR THE EXCELLENT WORK!!!!!!!!

Ack!
you're absolutely right.

for anyone that already patched the above, please re-download.

Here is what i added to account for hosts added to a tree without a header branch.


.fri

I've added this to SVN, with a few minor updates. Everything has worked perfectly on my test machine, and I will test it on a larger install in the next few days.

Hey Jimmy,

I'd like to see what the svn code looks like, as the svn site doesn't seem to include the monitor plugin.
Yesterday I cleaned up the code a bit more (refactoring your original a bit)

Also, an idea I threw in there is the ability to show percent up for a tree branch (commented out). I will not update the above post until you ok it.

.fri

Good works thats greatest

Hello,
First i would like to congratulate for this new pacth... Very nice.

Second, i´ve just tested this patch and realised one little bug.

I have created one user that have permissions to view especific hosts. When i logged with this user the monitor view is ok because he can see only the hosts that he has permissions to view. But the alert sound that indicates a host goes down begins as any one host is down, even this one is not in user´s view. In fact, there is a host down in another group of hosts, but not in this group that i set for this user.
This means that the view is ok, it is showed depending on user´s permissions, but apparently there is no treatment to sound alert per permission. The monitor is alerting wenever any host goes down, even for that one wich is not in the user permissions.


Perhaps i might be wrong and the problem may be i´m doing something wrong. In this case, please let me know.

sorry my english...

fernanda,

you are exactly right, I'll work on a quick update addressing this issue.

.fri

Wow, I LOVE this bit! But I'm concerned about differences between SVN code the the published stuff at this thread
Reinhard

Yes that is why I am continuing to work on the features described above but will wait to see SVN before posting more code.

Thanks.

.fri

Ok I have finished working with these monitor changes and I hope the code changes I have made will benefit future changes.

Attached please find my current changes added to svn.



Ideas commented out:
include total hosts in group in title
include percent of hosts up in title
rendering simple list form
time taken to process page

Thanks to jimmy for making the current codebase accessible.

.fri

Fri- thanks for the new version of MONITOR - it looks great. However, when I choose the TREE view, all of my hosts are grouped under one tree only. The 0.7.2 version worked fine ???

Lines:

if (sizeof($leafs) > 0) {
$currentTitle = $tree["name"];
$result .= render_branch($currentTitle,$leafs);
}

Appear to be missing from the new version - where does this code get inserted ?

Can you help ?

Thanks

Hey mcutting,

Well to start, please describe your tree setup and what is being rendered. For example,

Default Tree
--> host
--> header
--> --> host
(just the monitored items)

Is Monitor just displaying a bunch of icons in the default way, or are you getting all your monitored hosts in a single group?

If you are looking for that code bit here it is:


That part will render the last branch with any remaining hosts (leafs).


.fri